[mythtv] Mythtranscode HLS/AVF heavily distorted output

[William Wilhelm]

The culprit was commit db5c40cfc14dcca456446fe059b01fe90211dd60.

This is the reversion diff.

diff --git a/mythtv/libs/libmythtv/mythframe.h 
b/mythtv/libs/libmythtv/mythframe.h
index 444b676..f27da5b 100644
--- a/mythtv/libs/libmythtv/mythframe.h
+++ b/mythtv/libs/libmythtv/mythframe.h
@@ -95,7 +95,7 @@ static inline void init(VideoFrame *vf, VideoFrameType 
_codec,
                          const int *p = 0,
                          const int *o = 0,
                          float _aspect = -1.0f, double _rate = -1.0f,
-                        int _aligned = 64) MUNUSED;
+                        int _aligned = 0) MUNUSED;
  static inline void clear(VideoFrame *vf);
  static inline bool compatible(const VideoFrame *a,
                                const VideoFrame *b) MUNUSED;
@@ -284,7 +284,7 @@ static inline int bitsperpixel(VideoFrameType type)
  }

  static inline uint buffersize(VideoFrameType type, int width, int 
height,
-                              int _aligned = 64)
+                              int _aligned = 16)
  {
      int  type_bpp = bitsperpixel(type);
      uint bpp = type_bpp / 4; /* bits per pixel div common factor */
diff --git a/mythtv/libs/libmythtv/videobuffers.h 
b/mythtv/libs/libmythtv/videobuffers.h
index 14fed78..b1f93c1 100644
--- a/mythtv/libs/libmythtv/videobuffers.h
+++ b/mythtv/libs/libmythtv/videobuffers.h
@@ -47,7 +47,7 @@ class YUVInfo
  {
    public:
      YUVInfo(uint w, uint h, uint size, const int *p, const int *o,
-            int aligned = 64);
+            int aligned = 0);

    public:
      uint width;

John are you able to test this on your end, and do you know what is 
going on here?
The original commit message is "Create pitch/strides that are a multiple 
of 32 bytes".

Thanks.

On 2015-07-29 20:28, William Wilhelm wrote:
> Still investigating, binary searching the commit history to figure out
> where it switched from good to bad. Will update when learn more.
> 
> 
> On 29 July 2015 8:26:31 pm John Pilkington <J.Pilk at tesco.net> wrote:
> 
>> On 25/07/15 08:48, William Wilhelm wrote:
>> > Ever since 0.27 -> 0.28, mythtranscode --avf/--hls has been giving very
>> > distorted output for transcodings of FTA recordings here in Australia.
>> > Prebuilt "nightlies" from Mythbuntu and my own weekly builds from master
>> > both experience this issue. Audio is unaffected.
>> 
>> If this is still a problem, or if you've solved it, it would be a good
>> idea to open a ticket.  Otherwise awareness may just fade away.
>> 
>> _______________________________________________
>> mythtv-dev mailing list
>> mythtv-dev at mythtv.org
>> http://lists.mythtv.org/mailman/listinfo/mythtv-dev
>> http://wiki.mythtv.org/Mailing_List_etiquette
>> MythTV Forums: https://forum.mythtv.org
> 
> 
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at mythtv.org
> http://lists.mythtv.org/mailman/listinfo/mythtv-dev
> http://wiki.mythtv.org/Mailing_List_etiquette
> MythTV Forums: https://forum.mythtv.org