[mythtv] Remove Fill Packets

[Richard Hulme]

On 27/04/15 16:35, Ryan Lavender wrote:
> On 24/04/15 20:17, Ryan Lavender wrote:
>> Hi Ryan,
>>
>> Ok, I've had a closer look at the code (not that I understand how all of
>> it fits together) and it seems that this feature is not (currently)
>> available for Firewire cards.
>>
>> stuarta has just pushed a change to Master to strip fill packets for
>> Firewire recorders. __https://github.com/MythTV/mythtv/commit/b0138ce__
>> should apply to 0.27 too so give it a go.
>>
>> Richard.
>>
>> Weird, but it doesn’t work for me. I get 0-byte recordings. What I did
>> to make it work was add this to firewiredevice.cpp:
>>
>> Put all of the content of the function BroadcastToListeners inside an IF
>> statement: if(!(data[1] == 0x1F && data[2] == 0xFF))
>>
>> However, mythtv sometimes has trouble tuning certain channels, and I
>> feel it may be related.
>
> I really don't know the code that well but I would guess that
> BroadcastToListeners is called whenever there is new data. That new
> data may not be the start of a packet, so your code will filter out
> chunks of data that happen to 0x1FFF in the 'wrong' place.
>
> I don't understand how the change stuarta made would cause 0-byte
> recordings unless *every* packet were padding (and then there would be
> nothing to watch anyway).
>
> Can you check that with no changes, everything works fine, but with the
> following, you get 0-byte recordings?
>
> bool FirewireRecorder::ProcessTSPacket(const TSPacket &tspacket)
> {
> const uint pid = tspacket.PID();
>
> if (pid == 0x1fff) // Stuffing
> return true;
>
>
> Richard.
>
> That is what happened when I tried it the first time. Would you like me
> to try it again?

Please.  As I said, it doesn't really make sense that that change would 
cause 0-byte recordings but since I don't know exactly what code changes 
you made, and I don't have the hardware to test it myself, it would be 
good to make sure that the 0-byte recordings really only occur when only 
that change is made.

Richard.