[mythtv] [mythtv-commits] Ticket #6974: last few seconds of video are not played

Jim Stichnoth stichnot at gmail.com
Fri Jan 4 19:15:15 UTC 2013

On Tue, Jan 1, 2013 at 8:12 PM, Mark Spieth <mark at digivation.com.au> wrote:
> On 1/2/2013 2:29 PM, Jim Stichnoth wrote:
>> On Mon, Dec 31, 2012 at 6:27 AM, Mark Spieth <mark at digivation.com.au>
>> wrote:
>>> updated patch to about trunk about 1 week ago.
>>> HTH
>>> mark
>> Mark,
>> Thanks for the update.  Your patch makes no mention of
>> MythPlayer::IsNearEnd(), which seems to be centrally involved with the
>> problem.  How is that dealt with?
> This is not necessary for this purpose.
> The key functionality is in MythPlayer::EventLoop where if the Eof state is
> delayed, it doesnt stop playing until there are less than 3 frames remaining
> to be played. 3 is arbitrary of course.
> The rest of the patch is to choose which mode to use for Eof processing.
> Also with the change around of Eof processing back to mythplayer from
> decoderbase, some aspects of the patch may be removable but I havent
> bothered to investigate this as yet. Works as is.
> Also check live tv handling. Should be the same (immediate eof mode) as
> before but havent tested this at all as its functionality I dont use.

My IsNearEnd() question was actually with respect to the
end-of-recording prompt, which still pops up 2 seconds before the end
even with your patch applied.  Are you also expecting to use something
like http://code.mythtv.org/trac/attachment/ticket/6974/mythtv-6974-IsNearEnd_margin_for_end_of_recording_prompt.patch


More information about the mythtv-dev mailing list