[mythtv] [mythtv-commits] Ticket #10793: CommFlagger improvements

[John P Poet]

On Sun, Jan 13, 2013 at 12:03 PM,  <noreply at mythtv.org> wrote:
> #10793: CommFlagger improvements
> -----------------------------------+-----------------------------
>  Reporter:  markspieth             |          Owner:  cpinkham
>      Type:  Patch - Feature        |         Status:  new
>  Priority:  minor                  |      Milestone:  unknown
> Component:  MythTV - Mythcommflag  |        Version:  Unspecified
>  Severity:  medium                 |     Resolution:
>  Keywords:                         |  Ticket locked:  0
> -----------------------------------+-----------------------------
>
> Comment (by bryan@…):
>
>  Replying to [comment:8 Wayne McDougall <waynemcdougall@…>]:
>  > ... Hope you find the feedback useful ...
>
>  I very much appreciate the feedback.  I went back through and cleaned up
>  my patches.  I've reduced it to 2 (they both overlap a little in
>  ClassicCommDetector): a new SceneChangeDetector and a new LogoDetector.
>  My other patch had made some more changes to the overall commflagging
>  method that may have been a bad idea for non-US so I decided to abandon
>  those changes.  These 2 (scene change and logo detection) have both worked
>  really well for me over the last 2 months.

Hi Bryan,

I recommend taking a look at a tool called quilt.  It makes "layering"
patches very easy.  For example, to clean up your last two patches so
they could be applied cleanly, I did:

$ patch -p1 < logo-detector.diff
$ quilt new scene-change
$ quilt fold -f -p1 < scene-change-detector.diff

Then I checked the reject file for anything obviously wrong.  Then I
generated a new scene-change patch will applies cleaning after the
logo patch:

$ quilt diff > scene-change-detector-v1.diff

To then clear out the quilt stuff

$ quilt delete

You can layer multiple patches with quilt, you just use "quilt new
<somename>" whenever you want to add a new "layer".

There are ways to do the same thing in git, but I am more comfortable
using quilt.


John