[mythtv] 0.27 code cleanliness

Gary Buhrmaster gary.buhrmaster at gmail.com
Tue Oct 9 17:36:51 UTC 2012


On Tue, Oct 9, 2012 at 1:56 AM, Stuart Morgan <stuart at tase.co.uk> wrote:
....
> We will generally accept patches against code written by MythTV developers. I
> stress that last part because the example you chose, RTjpegN.cpp, is in fact
> third party code that we've included into our code base, we normally don't do
> code formatting and correctness fixes for those because it would make re-
> syncing them harder. RTjpeg may even be dropped in favour of more modern
> codecs.

Yes, there are a lot of (especially) filters that should probably just
"go away",
and some source files that I think may be essentially abandonware by the
original author(s)/project(s).  In other cases, the current versions have
substantially deviated from when they were originally incorporated into
MythTV.  A lot of work to review (and in some cases refactor), of course,
with little return on the investment.

> If you do supply patches, please split them up into bite-size chunks,
> preferably not touching multiple libs, or too many files at once. This will
> make them easier to review and easier to apply, especially if one of the files
> changes before we can get to that point.

Thanks.  I know those rules (and have "reminded" others to do the same
in other projects I work on ("Your patch is too big to review, try again" :-)).

btw, you might want to add these rules to the appropriate (wiki?) pages
so that others are aware of them.

Thanks.

Gary


More information about the mythtv-dev mailing list