[mythtv] Ticket #9726: Unicable / Satellite Channel Router / DIN EN 50494
Warpme
warpme at o2.pl
Sun Oct 7 09:08:39 UTC 2012
On 10/7/12 9:15 AM, MythTV wrote:
> #9726: Unicable / Satellite Channel Router / DIN EN 50494
> -----------------------------+-----------------------------
> Reporter: twoof7@… | Owner: stuarta
> Type: Patch - Feature | Status: assigned
> Priority: minor | Milestone: unknown
> Component: MythTV - DVB | Version: Master Head
> Severity: medium | Resolution:
> Keywords: | Ticket locked: 0
> -----------------------------+-----------------------------
>
> Comment (by dekarl@…):
>
> Some questions after looking at
> [[attachment:0037-mythtv-0.26-resend_disecq_cmds.patch]]
>
> What happens if the setting is exactly 10?
For value=10 it should behave like value=0: resend is disabled
>
> Why can you repeat 9 times but only resend 5 times?
Originally repeat was limited to 5. I think resend/repeat more than 3
times practically don't make sense as if I can't imagine disecq
installation with so low quality that going with 4 or 5 improves while
overall quality is acceptable at all.
I choose boundary at 10 simply for simpler math.
Limit of 9 for repeat is side effect as SpinBoxSetting has only support
only for continuous range of input.
>
> Wouldn't it be easier to understand with separate settings for separate
> concerns? e.g. repeat_count and repeat_mode/_kind instead of the <10 or
> >10 kludge
>
Sure. If UNICABLE will be ever integrated in mainline code, I think
definitely will be better to have "repeat cmd" spinbox + "skip repeat
flag" checkbox + appropriate help legend.
Unfortunately this will require additional field in disecq tree table
(+all DB upgrade stuff, etc).
My approach here is rather prof-of-concept + collecting knowledge about
what should be implemented for reliable production quality unicable
support. If anybody from devs will decide to refactor
dvbchannel/disecqtree for unicable support - this ticket can be nice guide.
For users not wanting wait for this, patches in this ticket allows to
start with unicable with lowest pain/shortest time (at least I hope that)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: warpme.vcf
Type: text/x-vcard
Size: 89 bytes
Desc: not available
URL: <http://www.mythtv.org/pipermail/mythtv-dev/attachments/20121007/84b4876c/attachment.vcf>
More information about the mythtv-dev
mailing list