[mythtv] Looking to commit code...

George Nassas gnassas at mac.com
Tue Mar 27 01:43:12 UTC 2012

On 2012-03-26, at 6:25 PM, David Blain wrote:

> If everyone agrees to re-locate the enums, I would be happy to add the
> needed code to the serialization classes.

There's no need to relocate the enums unless people really want to. Also, wouldn't you be introducing a circular dependancy? The recording classes would depend on the serializing classes for enums but the serializing classes would depend on the recording classes for parameter types.

It's easy to wrap macros around whatever enums are needed and have them declared in multiple places and that takes care of the out-of-sync issue. It shouldn't take me very long to disentangle my macros from my QMeta* adventuring and I can have a patch ready shortly.

Will your serializing code handle bitmask fields like recording.videoProps and audioProps? That's what got me into this in the first place. I think it makes sense to have bitmasks go out as maps where the enum symbols are keys and the values are booleans.

- George
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mythtv.org/pipermail/mythtv-dev/attachments/20120326/09e55b55/attachment.html>

More information about the mythtv-dev mailing list