[mythtv] 0.25 Parental controls, Trac #10388

Bill Meek keemllib at gmail.com
Sun Mar 4 23:55:16 UTC 2012


Sorry for not replying to list, its not available.

Possible solution for: http://code.mythtv.org/trac/ticket/10388

The default starting parental level gets read from the database in

   programs/mythfrontend/videodlg.cpp VideoDialog::Init().

However, VideoDialog::Init() runs after

   programs/mythfrontend/videofilter.cpp VideoFilterSettings::matches_filter(),

so m_parental_level always = 0 (ParentalLevel::plLowest) when mythfrontend
starts. This is consistent with the discussions on the -users list.
(http://www.gossamer-threads.com/lists/mythtv/users/506306)

Reverting 2 lines from commit 7c8e45f appears to fix the problem.
(https://github.com/MythTV/mythtv/commit/7c8e45f)

Tested on v0.25pre-4783-g79f5133. I did not test the case where
there were no videos, I believe the intention of the commit.

diff --git a/mythtv/programs/mythfrontend/videodlg.cpp b/mythtv/programs/mythfrontend/videodlg.cpp
index ab61eb6..f953cf5 100644
--- a/mythtv/programs/mythfrontend/videodlg.cpp
+++ b/mythtv/programs/mythfrontend/videodlg.cpp
@@ -1027,6 +1027,8 @@ bool VideoDialog::Create()
                  SLOT(UpdateText(MythUIButtonListItem *)));
      }

+    connect(&m_d->m_parentalLevel, SIGNAL(SigLevelChanged()),
+            SLOT(reloadData()));
      return true;
  }

@@ -1035,8 +1037,6 @@ void VideoDialog::Init()
      m_d->m_parentalLevel.SetLevel(ParentalLevel(gCoreContext->
                      GetNumSetting("VideoDefaultParentalLevel",
                              ParentalLevel::plLowest)));
-    connect(&m_d->m_parentalLevel, SIGNAL(SigLevelChanged()),
-            SLOT(reloadData()));
  }

-- 
Bill


More information about the mythtv-dev mailing list