[mythtv] [mythtv-commits] Ticket #10250: Big Mythgame patch

Robert McNamara robert.mcnamara at gmail.com
Tue Jan 10 15:40:22 UTC 2012

On Tue, Jan 10, 2012 at 6:45 AM, Stuart Morgan <stuart at tase.co.uk> wrote:

> On Tuesday 10 Jan 2012 14:23:20 MythTV wrote:
> > #10250: Big Mythgame patch
> > Comment (by psycho_driver@…):
> >
> >  My concern with a single rating value is that if a user changes the
> >  rating, and then does a metadata refresh which pulls a rating value, the
> >  user-assigned value will be overwritten.  I suppose one way of avoiding
> >  this would be to not overwrite any non-zero rating value with new
> >  metadata.
> Once you own a title does the rating given by other people matter? I
> understand how a rating can help in the decision to obtain a
> game/video/other
> but surely after that it's your opinion, your rating, which is important.
> So I
> don't see the need for two rating fields and we shouldn't overwrite the
> user's
> rating.
> > A downside to this would be that the rating would remain static
> > after an initial pull, even if it had shifted significantly on the
> source.
> So the only way that that it becomes an issue is if you've acquired a game
> but
> don't play it for a very long period (weeks/months) - just how likely is
> that?
> If you've played it you've formed your own opinion and changed the rating
> so
> you're no longer interested in the one from the metadata source.
> I often find myself in a minority on these sorts of issues, I clearly don't
> always understand my fellow man so maybe I'm wrong.

You may or may not be in the minority, but I agree with you-- your
reasoning above is more or less why I prefer the approach we take in all
the other plugins and the reasoning behind my request on the ticket.

I've done some work (though not as much as I would like) in the past few
years to try to bring MythGame more in line with the other metadata
browsing and playback plugins.  Another strong reason to keep the ratings
values the same as elsewhere is a "feel" of overall consistency-- if the
user expects the metadata source to fill the rating, and then be able to
edit it in MythMusic, MythVideo, etc. then the same should go for MythGame.

A lot of the comments I made on the ticket are based on a desire for
consistency, eg, recording and video metadata download picks the first item
from the artwork (which in the case of those grabbers is ostensibly the
highest rated) and pulls it in automatically as part of a metadata grab.
 If the user wants to change artwork, they should have that option, but it
shouldn't make quick n' dirty metadata grabbing a chore.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.mythtv.org/pipermail/mythtv-dev/attachments/20120110/deefeecd/attachment.html 

More information about the mythtv-dev mailing list