[mythtv] [mythtv-commits] mythtv/master commit: 624c23c56 by Michael T. Dean (sphery)
Michael T. Dean
mtdean at thirdcontact.com
Thu Mar 3 17:11:22 UTC 2011
On 03/03/2011 07:52 AM, David Asher wrote:
> On Mar 2, 2011, at 7:25 PM, MythTV wrote:
>> Author: Michael T. Dean<mdean at mythtv.org>
>> Change Date: 2011-03-02T16:25:10-08:00
>> Push Date: 2011/03/02 16:25:37 -0800
>> Repository: mythtv
>> Branch: master
>> New Revision: 624c23c56d21ee2840aef24d9f447baa54eb7d84
>> Changeset: https://github.com/MythTV/mythtv/commit/624c23c56
>> Allow near-end bookmarks for in-progress recordings.
>> When exiting in-progress recordings, what's now near the end may not be
>> near the end later, so go ahead and set a bookmark (for those who have
>> specified "Save position and exit"), so users don't lose their place.
>> I didn't modify MythPlayer::SetWatched(), since I have a feeling quite a
>> few users will watch in-progress recordings and exit after the end of
>> the show, but before recording stops--in which case they have watched it
>> and just want to be done with it (rather than have to manually mark it
>> watched). On the other hand, users who watch until they're caught up
>> with current time then exit before the end of the show will likely come
>> back to finish watching the recording sooner, rather than later (so it
>> will be watched soon enough). Alternatively, if the auto-detection does
>> the wrong thing, they can choose to mark the show unwatched.
>> Since we can't always do the right thing automatically, I'm trying to
>> guess what's likely right for the most people. That said, I have some
>> projects in the works to improve both bookmark and watched handling.
>> Fixes #9625.
> Wouldn't a more intuitive way to do this be basing the decision on the actual end time of the recording in progress?
Yes, but what I didn't say is that I need to rewrite SetWatched() to
account for changes to MythTV since it was first written. When I do
that, I will handle the in-progress recordings better, but I didn't want
to waste time on code that needs replacing. :)
More information about the mythtv-dev