[mythtv] [mythtv-commits] Ticket #8585: Qt:ISODate/mysql icompatibility

[Michael T. Dean]

On 03/03/2011 08:54 AM, Simon Kenyon wrote:
> On 02/03/2011 20:00, MythTV wrote:
>> #8585: Qt:ISODate/mysql icompatibility
>> ----------------------------------+----------------------------
>>    Reporter:  eltorio@…             |          Owner:  mdean
>>        Type:  defect                |         Status:  new
>>    Priority:  minor                 |      Milestone:  unknown
>> Component:  MythTV - General      |        Version:  Trunk Head
>>    Severity:  medium                |     Resolution:
>>    Keywords:                        |  Ticket locked:  0
>> ----------------------------------+----------------------------
>>
>> Comment (by Michael T. Dean):
>>
>>    Don't use QDateTime::toString() for prepared queries.
>>
>>    When using bindValue() to specify datetime values, do not use
>>    toString().  Instead, pass the QDateTime to bindValue() so that it can
>>    pass the value using the MySQL-C-API MYSQL_TIME type--so that database
>>    datetime string literal format isn't an issue.  Refs #8585.
>>
>>    Thanks, again, to Rob Smith for finding another incorrect pattern to
>>    search for.
>>     Changeset: cd073b6e9b323958f785cab47884e605e4033885
> is the the opposite to what
>
> Gentoo/media-tv/mythtv/files/mysql-5.5.patch
>
> is doing? this appears to be adding them.

Yes, but the only reason mysql-5.5.patch was using toString() was to 
make sure that the -v database logging wasn't showing the Qt-format 
times in its output, to make grep'ing the logs for invalid-format 
datetimes much easier.  And, Rob has since replaced that patch in the 
ebuild with the simpler 
mythtv-8585-use_proper_ISO_SQL_format_in_database_logging.patch (which, 
again, is only really useful for those who are grep'ing log files to 
find any invalid usage).  If you pull an update, you'll get the new ebuild.

Mike