[mythtv] MHEG BBC iPlayer

[Lawrence Rust]

On Fri, 2011-07-22 at 11:03 +0100, Duncan Brown wrote:
[snip]
> Patches applied fine against current git, but then building bombs with 
> the following:
> 
> mhi.cpp: In member function 'virtual bool MHIContext::BeginStream(const 
> QString&, MHStream*)':
> mhi.cpp:857: error: cast from 'MHStream*' to 'unsigned int' loses precision
> mhi.cpp: In member function 'virtual void MHIContext::EndStream()':
> mhi.cpp:898: error: cast from 'MHStream*' to 'unsigned int' loses precision
> mhi.cpp: In member function 'bool MHIContext::StreamStarted(bool)':
> mhi.cpp:911: error: cast from 'MHStream*' to 'unsigned int' loses precision
> make[2]: *** [mhi.o] Error 1
> make[2]: Leaving directory 
> `/root/rpmbuild/BUILD/mythtv-0.24.1/mythtv-0.24/libs/libmythtv'
> make[1]: *** [sub-libmythtv-make_default] Error 2
> make[1]: Leaving directory 
> `/root/rpmbuild/BUILD/mythtv-0.24.1/mythtv-0.24/libs'
> make: *** [libs] Error 2
> error: Bad exit status from /var/tmp/rpm-tmp.dWQN5M (%build)
> 
> I'm by no means an expert on building, and in all honesty don't know 
> what I'm doing 100%, but there you go.

I take it that you're building for 64-bit?  The error message is related
to casting a 64-bit pointer to a 32-bit int for log output.  I'll amend
the code to use a 64-bit compatible type.

Actually, I believe that the compiler is wrong to emit an error here.  A
warning is acceptable, but the code includes an explicit cast from
pointer to int which the compiler should honour.  Are you using
additional compiler warning options?

> Looking forward to this very much though!

OK, I've fixed the patch.  Try re-downloading and building.

Thanks for your feedback.

> cheers
> 
> Dunc
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at mythtv.org
> http://www.mythtv.org/mailman/listinfo/mythtv-dev


-- 
Lawrence