[mythtv] Fwd: Re: [mythtv-commits] Ticket #9400: MacOS X Compile failure

[Lawrence Rust]

On Tue, 2011-01-11 at 10:50 -0800, Gavin Hurlbut wrote:
> On Tue, Jan 11, 2011 at 2:23 AM, Jean-Yves Avenard
> <jyavenard at gmail.com> wrote:
>         
>         There's more than avformat to link to, there are references to
>         at
>         least libavcodec and libavutil.
>         
>         The reason I used weak linking was to make sure libmyth didn't
>         have to
>         be linked to 3 extra libraries...
>         
>         I specifically recall a time where libmyth got added the
>         dependency to
>         libavcodec to be told in quite strong word to remove it...
>         
>         
>         
> 
> 
> libavcodec is already there at this time, as is libavutil and
> libavcore (although that one had a typo I fixed as well).  I see no
> reason why at this point we should keep libavformat out of there,
> particularly as the weak linking breaks OS X and Windows builds.  That
> mess needs a serious rework anyways, but in the mean time, I think we
> can settle for "just working" :)

It's trivial to keep the weak import just for Linux:

#if defined __linux__ || defined __linux
pragma weak av_guess_format
...
#endif

Plus some conditionals in libmyth.pro

Can someone explain why it's so desirable to avoid linking with these
ffmpeg libs?  The same libs are used by other myth libs and the extra
build time and runtime overhead are small.

-- Lawrence