[mythtv] mythtv/master commit: 38f8fb1f2 by David Engel (gigem)

[Gavin Hurlbut]

On Sun, Feb 27, 2011 at 8:30 PM, David Engel <david at istwok.net> wrote:

> On Sun, Feb 27, 2011 at 01:35:08PM -0800, Gavin Hurlbut wrote:
> > Just curious. It seems that the if/else if structures could just be
> if/else.
> > Any particular reason to check the status twice?
> >
> > If(a) else if(!a) seems odd to me.
>
> Perhaps I'm missing something, but that isn't the construct in the
> code.  It is "if(a) else if (!b)", where a is rsRecording and b is
> rsRecorded.  The intent is to perform the following transitions.
>
> Yeah, on second look, it is just that, sorry.  It was the confusing names
(rsRecording and rsRecorded) that caught me during a low-caffeine moment :)

if(a) else if(!looks_like_a)...

Not to worry.  I'm glad that this cleanup's being done, though.  We have so
many little messy spots that can use some love.

Now to go make more coffee so my brain can continue operating.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.mythtv.org/pipermail/mythtv-dev/attachments/20110227/ed61d259/attachment.html