[mythtv] Any tv_grab_eu_epgdata users running master? (was Re: [mythtv-commits] mythtv/master commit: 8b0daaf01 by Michael T. Dean (sphery))

[Michael T. Dean]

On 08/29/2011 06:26 AM, Jan Schneider wrote:
> Zitat von "Michael T. Dean":
>> On 08/28/2011 09:32 AM, Jan Schneider wrote:
>>> Zitat von "Michael T. Dean":
>>>> On 08/27/2011 05:25 PM, Michael T. Dean wrote:
>>>>> On 08/27/2011 05:01 PM, MythTV wrote:
>>>>>>           Author:  Michael T. Dean<mdean at mythtv.org>
>>>>>>      Change Date:  2011-08-27T14:00:08-07:00
>>>>>>        Push Date:  2011/08/27 14:01:21 -0700
>>>>>>       Repository:  mythtv
>>>>>>           Branch:  master
>>>>>> New Revision:  8b0daaf01f00605a424e95e55d0d62ab60827d70
>>>>>>        Changeset:  https://github.com/MythTV/mythtv/commit/8b0daaf01
>>>>>>
>>>>>> Log:
>>>>>>
>>>>>> Fix inefficiency in marking first/last showings without programids.
>>>>>>
>>>> Oh, and FWIW, any 0.24-fixes users who are compiling the code themselves
>>>> can apply the patch and test it, too.  The master-branch changeset will
>>>> apply directly to 0.24-fixes with offsets (about 290 lines or so).
>>>>
>>>> https://github.com/MythTV/mythtv/commit/8b0daaf01.diff
>>>>
>>>> for the patch.  Log files greatly appreciated.
>>> It's a difference like night and day. I rebuilt the mythbuntu package
>>> with the patch backported, and this is the log output:
>> ...
>>> 2011-08-28 15:26:37.167 Marking episode first showings.
>>> 2011-08-28 15:28:10.014     Found 34120
>>> 2011-08-28 15:28:10.014 Marking episode last showings.
>>> 2011-08-28 15:29:53.172     Found 34194
>> Excellent.  That looks good compared to the 30-min runs you were seeing
>> before.
>>
>> Just to make sure it's properly marking things (since I know you have
>> quite a few without programid), can you provide the output of:
>>
>> select sum(first), sum(!first), sum(last), sum(!last), count(*) from
>> program;
>    sum(first): 54977
> sum(!first): 158464
>     sum(last): 54612
>    sum(!last): 158829
>      count(*): 213441
>
>> and
>>
>> select sum(first), sum(!first), sum(last), sum(!last), count(*) from
>> program where programid = '';
>    sum(first): 53570
> sum(!first): 158334
>     sum(last): 53221
>    sum(!last): 158683
>      count(*): 211904

Heh, no wonder you're seeing severe problems from our little 
inefficiency--nearly all of your shows have no programid.  Seems UK RT 
data has programid for a good proportion of listings, so even with their 
long descriptions aren't nearly as badly affected.

>> Also, out of curiosity, did you backport only the change that limits the
>> amount of description we use for sorting ( 8b0daaf01 , as above), or did
>> you also backport https://github.com/MythTV/mythtv/commit/17955f890
>> ("Take advantage of prepared queries in mythfilldatabase.")?
> Only the LEFT() limiting commit.

OK, great.  Thanks for the testing and info.  I'll go ahead and get the 
change backported today.

Mike