[mythtv] [mythtv-commits] Ticket #8999: [PATCH i18n] Remove empty source string from NB MythMusic translation

[Nicolas Riendeau]

Hi!

On 9/24/2010 1:29 PM, Nick Morrott wrote:
> doesn't handle them correctly - whether the "correct" handling would
> be for lupdate to delete them I can't say - and includes them as valid

I think Qt Linguist complains about them and removes them...

(But not everyone uses Qt Linguist unfortunately...)

> translations, only for lrelease to not translate them. This results in
> differences in the number of translations reported by the two tools.
> Once removed from a .ts file they shouldn't reappear unless a
> translator is using an old checkout and submits a diff which adds them
> back.

Which is a possibility nonetheless...

> Before sending the patch I grepped the current source and this was the
> only empty string found, after the efforts last week to locate and
> remove them all, and I'll try to keep an eye on things as we near the
> release.

What I am somewhat curious about is how they got introduced in the files...

For mythmusic, it looks like they appeared in changeset 18999 
(http://svn.mythtv.org/trac/changeset/18999) which is a pretty old 
changeset...

And, if I'm reading this right and from a quick glance at the code, 
themestrings/themestringstool was fixed so that it would not generate 
this at changeset 22188 (http://svn.mythtv.org/trac/changeset/22188).

BTW, do you think you could modify your program that makes the 
translation completion report so that it logs these and returns a 
different return code when they occur (which you could act on and send 
yourself an email or something like that)? You already have to parse the 
entire file anyway, no?

>
>>   PS: I did not regerate the qm files since they were not affected.
^that should have been regenerate...
>
> Perfect - the patch was only removing a string that lupdate and
> lrelease can't handle.

Yep, I know.... I just wanted to make sure people understood why it 
wasn't done... That comment wasn't actually directed toward you since 
you probably already knew this wasn't necessary but toward other people 
reading that comment... (-;

Have a nice day!

Nicolas