[mythtv] [mythtv-commits] Ticket #8426: mythgallery does not follow xorg.conf aspect ratio for non-square pixels

[Stuart Morgan]

On Wednesday 05 May 2010 22:15:03 MythTV wrote:
> #8426: mythgallery does not follow xorg.conf aspect ratio for non-square
>  pixels
>  ----------------------------------+---------------------------------------
> -- Reporter:  Woodhouse             |       Owner:  ijr
>      Type:  defect                |      Status:  new
>  Priority:  trivial               |   Milestone:  unknown
> Component:  Plugin - MythGallery  |     Version:  0.23rc3
>  Severity:  low                   |     Mlocked:  0
> ----------------------------------+----------------------------------------
> -
> 
> Comment(by Jonatan <mythtv@…>):
> 
>  Replying to [comment:5 stuartm]:
>  > Thanks for the response. This isn't going to be a quick fix, there have
> 
>  been zero changes in mythgallery between 0.22 and 0.23. The fullscreen
>  image code doesn't use the common ui libs so at this moment in time I
>  can't come up an explanation, it appears to have broken for no reason at
>  all.
> 
>  I think there are two issues here.  The first one is that
>  MythGetPixelAspectRatio() returns 1.0 since 0.22.  The second is that
>  QImage::ScaleFree should have been replaced with Qt::IgnoreAspectRatio
>  instead of Qt::KeepAspectRatio when porting to Qt4.

Whilst I don't doubt that both of those contribute to the problem, it 
contradicts what the original reporter indicated. Namely "This is regression 
as it worked properly on my previous mythbuntu 9.04 setup. (mythtv 0.22)". The 
QT4 port occured between 0.21 and 0.22 and MythGetPixelAspectRatio() was also 
broken in 0.22.
-- 
Stuart Morgan