[mythtv] [mythtv-commits] Ticket #7336: Re-implement "Delete Recordings" after MythUI port

[Robert McNamara]

On Mon, Mar 1, 2010 at 6:56 PM, Nigel Pearson <nigel at ind.tansu.com.au> wrote:
>
>> I guess the frustrating part of this is that it is no more optional
>> than any other screen in myth, then.
>
> True, although I was more frustrated by two menu buttons
> doing exactly the same thing than the theme clash.
>
>
> Question... should themers be able to override the function
> of the appliance, or just the eye-candy? If the former,
> then the code could use *menu.xml from the themes?
>
> Thought... if people really hate the Delete Recordings screen,
> maybe discussion or a ticket should be raised to remove
> it from the default menu?

Personally speaking, I liking giving as much flexibility as possible
to the themers.  XBMC is essentially a fully scripted UI and some of
the more imaginative themers on their side use it to great effect.
Chris Pinkham has mentioned interest in allowing the theme to
recommend a menu and OSD theme, and I think this is a neat idea and a
prelude to hopefully allowing more of this kind of customization in
the future.

If anyone else feels strongly enough about the behavior to speak up
about it, hopefully they will, I only know from casual discussions
that others felt somewhat as I did-- I do completely concede and agree
that having both menu items doing the same is silly. (But my instinct
is to say that adding a second themable screen that is all doable in
watch recordings doesn't feel right)

>
>> If a theme is missing that window,
>> it falls back to watch recordings - the current behaviour."
>> That doesn't seem to be the case.
>
> It was for the first change [23293], but then I went
> and committed the default and default-wide changes.
>

Gotcha, thanks for the clarification.

> ...
>> Personally, I see no advantage to the screen existing at all,
>> especially in a theme like Arclight where the space is displayed in
>> Watch Recordings.
>
> Well, not all themes do display the usage, and my household was
> annoyed at having to go into System Status, scrolling over to
> Machine Status, and then scrolling down past the slaves to total.
>

Understood.

>
>>  I am not certain, but I think if the window
>> definition was removed from default and default-wide, and only added
>> to themes that specifically elect to use it, that it might behave as
>> you had described, but if it exists in the defaults, loadfromxml will
>> *always* return true and the fallback will never happen.
>
> Correct.
>
>
>
> I will consider removing the window def from default*,
> and maybe adding it into Metallurgy.
> Gimme a few days to get feedback (and some sleep).
>

No worries, hopefully if anyone else has thoughts on this matter
they'll respond.  Worst case scenario for me, it's not the end of the
world to cut and paste the contents of watchrecordings into
deleterecordings.

Thanks again,

Robert