[mythtv] [mythtv-commits] Ticket #7336: Re-implement "Delete Recordings" after MythUI port
robert.mcnamara at gmail.com
Tue Mar 2 01:35:50 UTC 2010
On Mon, Mar 1, 2010 at 4:55 PM, Nigel Pearson <nigel at ind.tansu.com.au> wrote:
>> I just found that in my authored themes, I am getting the default-wide
>> delete recordings page, rather than it being optional as this ticket
>> led me to believe it was. I am strongly against the delete recording
>> page existing at all, but felt okay about this one since it purported
>> to be optional. Can you comment?
> Certainly. It is optional in a few ways:
> 1) A user could remove it from the menus, or
> 2) A themer could override (the inherited default version)
> to an empty "deleterecordings" window definition, so that
> nothing happens when the user selects that button, and
> 3) A themer can override (the inherited default version)
> with an exact copy of their themed watchrecordings window,
> so that it behaves the same as before my commits.
I guess the frustrating part of this is that it is no more optional
than any other screen in myth, then. Your description of the patch in
the ticket notes: "The attached patch allows themes to have a custom
'deleterecordings' window which is loaded from that button, and adds
it to the current standard themes. If a theme is missing that window,
it falls back to watch recordings - the current behaviour." That
doesn't seem to be the case. I think at least a couple of us who were
troubled by the restoration of this screen were placated by that
description and so kept quiet, but it doesn't seem to behave as
advertised. Do you have any inclination to make it do so?
Personally, I see no advantage to the screen existing at all,
especially in a theme like Arclight where the space is displayed in
Watch Recordings. I am not certain, but I think if the window
definition was removed from default and default-wide, and only added
to themes that specifically elect to use it, that it might behave as
you had described, but if it exists in the defaults, loadfromxml will
*always* return true and the fallback will never happen.
Not intending to badmouth your hard work, just a little surprised by
how this ended up working.
More information about the mythtv-dev