[mythtv] [mythtv-commits] Ticket #8669: Remove "Change channels immediately without select" setting

[Ian Campbell]

On Tue, 2010-07-20 at 14:04 -0400, Michael T. Dean wrote:
> On 07/19/2010 05:26 PM, MythTV wrote:
> > #8669: Remove "Change channels immediately without select" setting
> >
> > Comment(by Ian Campbell):
> >
> >   The "Change channels immediately without select" setting is already
> >   disabled in my configuration ( doubled checked the DB and
> >   SmartChannelChange == 0). Did you mean for me to enable it? (From what you
> >   say I don't think so).
> >
> >   Note that I see the issue with recorded rather than live TV (I haven't
> >   tried live), does "change channel" have any meaning in that context?
> >
> >   I have heavily instrumented tv_play.cpp and I am definitely seeing the
> >   queueInputTimerId timer firing pretty much immediately after I press any
> >   numeric button and causing the queuedInput to be wiped. 10ms for this
> >   timer can't be right, can it?
> >
> 
> Ian, none of the people I've talked to have been able to reproduce the 
> issue you're seeing.

Hmm, well thanks for trying!

> The code your patch changes has existed since the mythtv-vid branch 
> merge prior to 0.22 release (in Dec, 2008).

IIRC this started happening when I updated to 0.23 earlier this year. I
wouldn't swear to it though.

> If you're applying any patches, please test with an unmodified version 
> of MythTV and see if you get the same behavior.

I'm running the Debian packages from debian-multimedia.org, it has a few
patches relating to locations of configuration files etc but nothing
which looks pertinent to this issue.

I suppose I should have mentioned already that my MythTV system and
hence my investigations were initially based on 0.23-fixes, sorry for
not thinking to mention this sooner. I did look through the trunk
history (24509 through HEAD) and diff the two versions of tv_play.cpp
and didn't see anything which looked like a possible fix so ported the
patch forward.

> If so, please try to 
> isolate which setting(s) is causing the issue so we can reproduce it and 
> fix it.

Will do, I guess the set of potentially interesting settings is those
added to the kv map in the TV:TV constructor (i.e. the thing passed to
MythDB::getMythDB()->GetSettings)?

FWIW my database contains the following for those particular settings:
+--------------------------+--------------+
| value                    | data         | Default
+--------------------------+--------------+
| AltClearSavedPosition    | 0            | "1"
| AutoExpireDefault        | 1            | "0"
| AutomaticSetWatched      | 1            | "0"
| BrowseAllTuners          | 0            | "0"
| BrowseChannelGroup       | 0            | "0"
| ChannelFormat            | <name>       | "<num> <sign>"
| ChannelGroupDefault      | -1           | "-1"
| ChannelOrdering          | channum      | "channum"
| ContinueEmbeddedTVPlay   | 0            | "0"
| CustomFilters            |              | ""
| EnableDVDBookmark        | 1            | "0"
| EndOfRecordingExitPrompt | 1            | "0"
| FFRewReposTime           | 50           | "100"
| FFRewReverse             | 0            | "1"
| GuiSizeForTV             | 0            | "0"
| IndividualMuteControl    | 0            | "0"
| JobsRunOnRecordHost      | 0            | "0"
| JumpToProgramOSD         | 1            | "1"
| OSDGeneralTimeout        | 2            | "2"
| OSDProgramInfoTimeout    | 3            | "3"
| PersistentBrowseMode     | 1            | "0"
| PlaybackExitPrompt       | 2            | "0"
| ShortDateFormat          | dd/MM        | "M/d"
| SmartChannelChange       | 0            | "0"
| SmartForward             | 1            | "0"
| TimeFormat               | hh:mm        | "h:mm AP"
| TryUnflaggedSkip         | 0            | "0"
| UDPNotifyPort            | 6948         | "0"
| UseArrowAccels           | 1            | "1"
| UseFixedWindowSize       | 1            | "1"
| VbiFormat                | PAL Teletext | ""
| WatchTVGuide             | 0            | "0"
+--------------------------+--------------+

I'll try playing with them, particularly the ones which are not the
defaults.

Ian.

-- 
Ian Campbell
Current Noise: Nine Inch Nails - Every Day Is Exactly The Same

First Law of Bicycling:
	No matter which way you ride, it's uphill and against the wind.