[mythtv] Ticket #7481: libavformat.diff patch to fix judder for german 720p HDTV channels ARTE HD, ZDF HD...

Robert McNamara robert.mcnamara at gmail.com
Tue Jan 19 00:57:39 UTC 2010


On Mon, Jan 18, 2010 at 4:50 PM, Kenni Lund <kenni at kelu.dk> wrote:
> I'm wondering, wouldn't it be best to have a patch like this included
> in trunk rather sooner than later? I mean, a lot of people depends on
> it and in this thread alone we're several users who are actively
> applying this patch and haven't (I can of course only speak for
> myself) had any issues with it. So it appears to be working from at
> least a few users perspectives...which I suppose would make it a
> candidate for trunk, if coding style and quality is ok?
>

Mere absence of problem (that the few users applied it noticed) is not
enough to get a patch included.  Neither, unfortunately, is simply
meeting coding standards.  Someone with the knowledge necessary to
know whether it will affect the countless other related bits of code
really needs to take a considered look at it.  It wouldn't do to fix
television for, say, Germany, but have the UK suddenly be unable to
watch television.  Not that I believe that would be the case here,
quite the opposite.  But until one of the people with the knowledge to
make that kind of guarantee (and fix anything that *might* get broken
as a result) takes a look at it, it remains in trac.  Patches go in
when they are reviewed by someone capable of giving them a stamp of
approval.  that hasn't happened just yet.

> Once it hits trunk there'll be a much larger userbase who can provide
> feedback. I suppose we're all just afraid that this will not make it
> for 0.23, which potentially in my case, would result in another ~6
> months until 0.24 gets released, with only half of the public TV
> channels working.

To be honest, this particular patch is unlikely to ever be in trunk.
Since the fix is from upstream ffmpeg, and since we will have an
ffmpeg sync in the next few days, that is how this code will end up in
trunk.  the only thing at issue is whether this patch will end up in
.22-fixes.  While I'm not able to guarantee that it will, I can say
that our "player people" do take seriously the current stable code, so
we'll just see what happens.

Robert


More information about the mythtv-dev mailing list