[mythtv] Feature: Configurable LIRC client name [PATCH]
foceni at gmail.com
Tue Feb 16 14:00:02 UTC 2010
On 02/16/2010 03:49 AM, Michael T. Dean wrote:
> On 02/15/2010 12:54 PM, David Kubicek wrote:
>> I'm sending a small patch that enables changing MythTV's LIRC client
>> ("program") name. This is quite useful when you have mythfrontend and
>> mythtv-setup or several mythfrontends open at the same time. All these
>> apps use "mythtv" client name by default, but by making this client
>> name configurable, I can use the existing command-line overrides to
>> allow different instances use a different name, hence different LIRC
> <my opinion>Die, new setting! Die!</my opinion>
> How about program = mythtv works for mythfrontend, mythtv-setup, ...
> program = mythfrontend works only for mythfrontend.
> program = mythtv-setup works only for mythtv-setup.
> No settings required. Then, if a user wants different keys for different
> client apps, they map them appropriately in their lircrc. Otherwise, the
> same mythtv that we've always used will work fine for the other 99.999%. :)
> It would require a bit more code, probably (as I haven't looked into the
> LIRC libs), but I really think we have enough settings--even if this
> would have been an "undocumented setting" (which may actually be worse
> than making it a setting with a GUI control, because it encourages
> direct DB editing).
That would certainly be an option and a working one too, but having one
application with two LIRC keys at the same time is... unusual and I
can't comment if it's possible at all with current LIRC integration in
MythTV. The new DB option is really intented only for CLI override, it's
not actually in the DB.
Like this, everything works as usual, it's just possible to change the
LIRC key on a per-application basis. If you don't agree with a DB
option, I could rework it and add a standalone new CLI option for this
value. This would certainly deserve one. That way, we keep the
compatibility, get rid of a new DB option and still can change how
MythUI apps identify themselves to LIRC.
In fact, that was how I intended to do it originally. I chose the
override interface simply because I found it there and it seemed
intelligent. A dedicated CLI option would make more sense, it's just
that it meant slightly more code too. :)
What do you say?
More information about the mythtv-dev