[mythtv] [mythtv-commits] mythtv commit: r23428 by skamithi

[stanley kamithi]

daniel,

i will revert the patch, pending your review.


On Mon, Feb 1, 2010 at 8:07 PM, Daniel Kristjansson <danielk at cuymedia.net>wrote:

> On Mon, 2010-02-01 at 17:30 +0000, mythtv at cvs.mythtv.org wrote:
> > Author: skamithi
> >         Date: 2010-02-01 17:30:32 +0000 (Mon, 01 Feb 2010)
> > New Revision: 23428
> >    Changeset: http://svn.mythtv.org/trac/changeset/23428
> >
> > Modified:
> >
> >    trunk/mythtv/libs/libmythtv/NuppelVideoPlayer.cpp
> >    trunk/mythtv/libs/libmythtv/vsync.cpp
> >    trunk/mythtv/libs/libmythtv/vsync.h
> >
> > Log:
> >
> > Refs #7067 patch from davin mccall. resolves av sync issues when watching
> certain dvds. simplified the interface between vsync and NuppelVideoPlayer.
> The videosync/vsync object now has no knowledge of the video framerate and
> instead gets the frame rate for each frame as part of the WaitForFrame call.
> tested it on various recorded shows, avis and dvds. no problem yet. applying
> to trunk to expand test audience.
>
> Stanley, I can't speak to how good or bad this solution is as I haven't
> reviewed it, but I don't think it is a good idea to apply an A/V sync
> or V-Sync patch this late in the release cycle.
>
> -- Daniel
>
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at mythtv.org
> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mythtv.org/pipermail/mythtv-dev/attachments/20100201/75b6af02/attachment.htm>