[mythtv] Ignore DefaultEndOffset in LiveTV record (tv_rec.cpp:NotifySchedulerOfRecording)

[Michael T. Dean]

On 02/01/2010 03:47 PM, David Kubicek wrote:
> Hello,
>
> does anybody know what's the reasoning behind ignoring
> DefaultEndOffset (m_endOffset) in TVRec::NotifySchedulerOfRecording?
> It's ignored when choosing to record current LiveTV program, but
> that's how I use DefaultEndOffset most often. :)

Default 'End Late' minutes for new recording rules
Set this to '0' unless you expect that the majority of your show times
will not match your TV listings. This sets the initial end late or end
early time when rules are created. These can then be adjusted per
recording rule.

As you can see, its purpose it to pre-fill the "End late" value for the
recording rule editor.  It is not designed to have any effect on the
scheduler.

> When I want to record what I'm watching right now (often), I have to
> start recording, stop watching (!), go to Watch Recordings, edit the
> program's rule, extend the schedule, go back to watching.
>
> I patched my SVN checkout to keep DefaultEndOffset honored, that's not
> a problem per se, but it just may have some unpredictably evil
> ramifications I'm not aware of. The scheduler is quite complex and I'd
> appreciate if somebody knew something about this measure.


You can submit the patch to Trac and someone (likely David Engel) will
review it and decide whether or not to accept the change.

However, I'll guess that if the patch actually changes the scheduler, it
won't be accepted.  If, instead, the patch changes the part of LiveTV
that creates the "virtual" recording rule for the show you were watching
in LiveTV, it's more likely to be accepted.

Mike