[mythtv] [mythtv-commits] Ticket #8656: Display video format in INFO OSD

[Robert McNamara]

On Sat, Aug 28, 2010 at 2:59 PM, Robert McNamara
<robert.mcnamara at gmail.com> wrote:
> On Sat, Aug 28, 2010 at 2:55 PM, Robert McNamara
> <robert.mcnamara at gmail.com> wrote:
>>>  (In [25889]) Better codec descriptions (than MPEG2) in the themed INFO
>>>  OSD. Refs #8656.
>>>
>>>  Currently, MythPlayer::GetEncodingType() uses GetVideoCodecID(),
>>>  which only iterates some of the FFmpeg codecs (plus, AVF's video_codec_id
>>>  is often mapped to MPEG2 in ScanStream()). Basically, a more opaque way of
>>>  getting codec descriptions was needed, and what is more opaque than a
>>>  string?
>>>
>>>  Technically, this changes the library API, but since only libmythtv is
>>>  calling the extra method, no version change - to save a full recompile.
>>
>> Hi Nigel,
>>
>> I think this may have broken the videocodec statetype?  MPEG-2 video
>> is no longer matching in the statetype, so OSDs that use the statetype
>> (Arclight) end up with nothing displayed when using the statetype.
>>
>> Robert
>>
>
> N/m, should be fixed now (assuming you can put up with having the (IMO
> more correct) dash in the codec names.
>
> Robert
>

Nope, only fixed for MPEG-2... but it breaks all the other codecs that
were working nicely-- I think there is something wrong here.  By
adding a text field, this appears to have broken the statetypes mark
added that are automatically populated by mythcodecidid.cpp.

Robert