[mythtv] Fwd: Re: [mythtv-commits] Ticket #8756: Impossible to skip back if you try and go before the beginning of the file

[Jonathan Martens]

On 10-8-2010 8:22, MythTV wrote:
> #8756: Impossible to skip back if you try and go before the beginning of the file
> -------------------------------------+--------------------------------------
>   Reporter:  ryan.goat@…              |           Owner:  mdean
>       Type:  defect                   |          Status:  closed
>   Priority:  critical                 |       Milestone:  0.24
> Component:  MythTV - Video Playback  |         Version:  Trunk Head
>   Severity:  medium                   |      Resolution:  fixed
>   Keywords:  jump backward            |   Ticket locked:  0
> -------------------------------------+--------------------------------------
> Changes (by markk):
>
>    * status:  assigned =>  closed
>    * resolution:  =>  fixed
>
>
> Comment:
>
>   (In [25600]) Fix skipping backwards when near the beginning of the file.
>
>   This was another side-effect of the ProgramInfo refactor and the
>   unsigned int wrapping around and producing unexpected behaviour. Live tv
>   needs a similar fix.
>
>   Closes #8756

I think you now have dead code as effectively desiredFrame can not be < 0:

3072	    uint64_t desiredFrame = (framesPlayed > number) ? framesPlayed
- number : 0;
3073	
3074	    if (desiredFrame < 0)
3075	        desiredFrame = 0;

Apart from that the same analogy applies for DoFastForward IMHO as that
is now allowed to skip past the end as well, which I am unsure if that
works or not.

Kind regards,

Jonathan