[mythtv] [mythtv-commits] Ticket #6376: Patch to save transcoded recordings

[Chris Pinkham]

* On Sun Mar 22, 2009 at 08:41:43AM -0400, Michael T. Dean wrote:
> On 03/21/2009 11:50 PM, Chris Pinkham wrote:
>> aren't using the Deleted group at all and should just have the .old file
>> as they do now.
>
> I started to type out the same thing in my first message, but after  
> considering it, I (someone who isn't using AutoExpireInsteadOfDelete )  
> decided that keeping the the original manageable by Myth was preferable.

My reasoning was that you aren't guaranteed that there aren't certain
places in the code dealing with the deleted group that only get run if
AutoExpireInsteadOfDelete is on.  For instance,
PlaybackBox::deleteSelected() checks AutoExpireInsteadOfDelete.
It looks like the other 2 places that use this setting are handled
explicitly by the patch, but someone down the road changing the
AutoExpireInsteadOfDelete functionality may not remember or know that
they need to check both AutoExpireInsteadOfDelete and SaveTranscoding.

> orphaned files).  Perhaps--since the "Deleted" recgroup is treated  
> specially and someone not using AutoExpireInsteadOfDelete may not  
> realize how to access it--if the user doesn't have both SaveTranscoding  
> and AutoExpireInsteadOfDelete enabled, just put it in another recgroup  
> (i.e. "Transcoded" or "Duplicate" or something)?

I like 'Transcoded'.  That makes it easy to find the originals and
delete them without having to wade through other groups that have other
things in them.  The Help text for the SaveTranscoding setting could
direct people to this special group as well.

--
Chris