[mythtv] [mythtv-commits] Ticket #6343: Problem with VDPAU and Temporal 2X deinterlacing

[Taylor Ralph]

> > >--------- Changes (by markk):
> > >
> > >  This is working as intended.
> > >
> > >  More advanced deinterlacers (not just in vdpau) typically
> > >  use 3 frames for
> > >  processing - with the middle frame intended for display.
> > >  This means there
> > >  is a 1 frame discrepancy between the audio and video
> > >  (which generally goes
> > >  unnoticed). When the deinterlacer is then disabled there
> > >  is a momentary
> > >  re-adjustment of the video. 
> 
> but here is the bug in mythtv, progressive frames wont
> passed thru to 
> deinterlacers where he can save the frame as reference for
> a possible 
> following interlaced frame. (applies too for last yadif
> bugfix)
> I've mentioned this in #4513.

Markus,

Thanks for the input but I'm not sure how this behavior affects VDPAU so I'll leave it alone.

Mark,

The VDPAU driver seems to already provide auto-deinterlacing. IMO the player code should probably not auto-detect interlacing when using VDPAU for deinterlacing. The provided sample video shows major glitches in the video that I believe have more to do with us turning the deinterlacing on and off and clearing the reference frames in the VDPAU driver. This can be totally avoided by skipping the AutoDeint() funtion in NuppleVideoPlayer. I've been running with this change for a couple days now and everything I have plays back perfectly now. It just seems the current method being used now is potentially unnecessary and is likely to cause problems as I'm already seeing. If we avoid AutoDeint() the manual user override will still function properly so I don't see the harm in doing this. I could be totally off base here and if so then I'm sorry. Just my humble opinion. Thanks again for the great job so far. It rocks!

--
Taylor