[mythtv] Ticket #7067: Initial DVD playback speed too fast.

[Taylor Ralph]

--- On Mon, 12/21/09, Taylor Ralph <tralph11 at yahoo.com> wrote:

> From: Taylor Ralph <tralph11 at yahoo.com>
> Subject: Re: [mythtv] Ticket #7067: Initial DVD playback speed too fast.
> To: "Development of mythtv" <mythtv-dev at mythtv.org>
> Date: Monday, December 21, 2009, 10:38 PM
> --- On Fri, 12/18/09, Davin McCall
> <davmac at davmac.org>
> wrote:
> 
> > From: Davin McCall <davmac at davmac.org>
> > Subject: Re: [mythtv] Ticket #7067: Initial DVD
> playback speed too fast.
> > To: "Development of mythtv" <mythtv-dev at mythtv.org>
> > Date: Friday, December 18, 2009, 6:15 PM
> > On 18/12/09 14:25, Taylor Ralph
> > wrote:
> > > Could you explain why in http://svn.mythtv.org/trac/changeset/22947/trunk the
> > following code was removed?
> > > 
> > > 1074        
> >     if (scan == m_scan)
> > > 1075        
> >         return;
> > > 
> > >    
> > 
> > Oh, and another thing: m_double_framerate needs to be
> > correctly initialized which only gets done inside
> > SetScanType(). If lines 1074 and 1075 are present,
> this
> > doesn't occur if the scan type happens to be
> > kScan_interlaced, which is what m_scan is initialized
> to.
> > 
> > Davin
> > 
> 
> Thanks for the information. This should be useful in
> figuring out how to resolve what you've discovered without
> excessive logging and CPU usage. I probably will not have
> time until after the holidays to look at this anymore.
> 

Davin,

I've attached a patch that should prevent the excess SetScanType() processing. Please review and see if it still provides the correct behavior for your DVD playback fixes. The patch should be applied to latest -fixes and trunk.

Thanks.

--
Taylor


      
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t7067_setscan_extra_checks.diff
Type: text/x-patch
Size: 2399 bytes
Desc: not available
URL: <http://mythtv.org/pipermail/mythtv-dev/attachments/20091224/41c599ef/attachment.bin>