[mythtv] Ticket #7759

Davin McCall davmac at davmac.org
Sun Dec 20 04:45:10 UTC 2009


Hi Taylor,

I was just looking at your patch in #7759 (Add support for repeat_pict 
plus related AV-sync improvements). Can you explain:

|2566:         repeat_delay = frame_int_erval * buffer->repeat_pict * 
0.5;_|

... why you halve the frame_interval when calculating the repeat_delay? 
(shouldn't this depend on whether m_double_framerate is set?) Also, 
wouldn't:

     repeat_delay = frame_interval / 2 * buffer->repeat_pict;

... be slightly better (avoid the floating point multiply, and allow the 
compiler to optimize it to a right shift)?

Davin



More information about the mythtv-dev mailing list