[mythtv] [mythtv-commits] Ticket #6943: Mythvideo filename parsing

Michael T. Dean mtdean at thirdcontact.com
Mon Aug 31 04:06:10 UTC 2009


On 08/30/2009 11:24 PM, Mythtv wrote:
> From: Michael T. Dean
>> On 08/30/2009 03:24 AM, MythTV wrote:
>>> #6943: Mythvideo filename parsing
>>>
>>>  The suggested fix (which I've now attached) doesn't break existing
>>>  functionality as the redundent space in the episode marker pattern is
>>>  handled equally well by the generic seperator pattern.
>> FWIW, the suggested fix /does/ break pattern matching for some of the 
>> previously-allowed formats.  The space was allowing all of space, 
>> period, dash, and underscore (as the others are replaced with spaces 
>> before the pattern matching).
...
>> The reason the fix is changing the behavior--even though the optional 
>> separator allows a space--is because the optional separator is, er, 
>> optional, but the episode separator is mandatory.  Therefore, removing 
>> space from the list of valid episode separators, means that /only/ e, x,
>> and episode are valid episode separators.
>>
>> However, Robert decided that it would likely be easier for users to 
>> understand why some formats fail if he just limited the list of valid 
>> episode separators to e, x, and episode, and no longer allowed space, 
>> period, dash, and underscore.
> Ah... didn't see that.
>
> How about this for an option then:
>   
...
> I think it covers all the issues.  The idea is to make the season marker
> compulsory, but to allow all the standard separators.  I've also removed
> the redundant non-capture declaration.

I think it's fine the way it is--Robert was probably right to make it 
more explicit so that it's more predictable behavior for users.  We 
probably shouldn't require them to learn exactly how it works to be able 
to make use of it, so with an explicit episode marker, it will be a lot 
easier to figure out.

Mike


More information about the mythtv-dev mailing list