[mythtv] [mythtv-commits] Ticket #6774: Perl Bindings do not Recognize H264
DISAFAN
disafan at aim.com
Sun Aug 9 17:26:20 UTC 2009
On 08/09/2009 01:37 AM, Michael T. Dean wrote:
> On 08/08/2009 10:40 PM, MythTV wrote:
>> #6774: Perl Bindings do not Recognize H264
>>
>>
>> Comment(by disafan):
>>
>> I've submitted a patch above. I'm not fluent in perl, but the above
>> modifications allow a fallback to the alternate DEMUXER for the
>> height and
>> width if the width = 0 and they modify the expression to allow VIDEO
>> H264
>> or VIDEO: MPEG2, thus eliminating the problems and allowing programs,
>> including Nuvexport(which was my goal), to stop throwing exceptions.
>
> Rather than fallback to the lavc demuxer, it makes more sense to just
> use it in the first place. I know lavc works fine for my (OTA ATSC)
> MPEG-2 and I would assume it would work fine for the MPEG-2 from ivtv
> and the MPEG-4 from Plextors (if anyone's still using those). And,
> since _nuv_info() is used for NUV, we shouldn't have to worry about it.
>
> Personally, I (the guy who does /not/ make the decision) would rather
> just replace the demuxer and wait to see if we get problem reports
> rather than write code that has to spawn a 2nd mplayer process for
> every H.264 program "just in case" there might be problems with
> currently-working recordings if we change the first run. As it is,
> load_file_info() /kills/ the system when run on all recordings, so
> making it 2x as bad is not a good thing.
>
The fallback won't run on every recording. I set it to only run if
width=0. A search indicates I'm not the only one who had problems with
the width=0 thing.
The issue is that using the alternate demuxer changes the values of
several other outputs. It would require changing other expressions to
accommodate the new responses. If you have an IVTV MPEG2, run both
commands and note the subtle differences. While that could easily be
fixed, I was afraid it might cause programs already depending on the
deciphered video type to fail.
The truth is, the width/height = 0 issue only seems to occur on the
HD-PVR recordings, and I'm not sure if it is all HD-PVRs or not. We'd
need feedback on that from other users.
I am also not the guy who makes the decisions. I can only state my
reasons for approaching it the way I did and let someone decide what is
better in the long run. In the short run, no more uninitialized values
and errors because it can't detect the source width and height.
> Ideally, though--since you probably don't have access to all the MPEG
> recording types out there--you'd post a little test script that takes
> a filename or chanid/starttime and outputs the fileinfo so others can
> apply the patch that changes demuxer and then test with their recordings.
>
> Thanks,
> Mike
More information about the mythtv-dev
mailing list