[mythtv] Unexpected commDetectMethod: 255

[Daniel Kristjansson]

On Mon, 2008-05-19 at 17:58 -0700, Gregorio Gervasio, Jr. wrote:
> I believe rev 17318 changed the definition of COMM_DETECT_ALL
> from 255 to a bitwise-OR of the available methods (currently a value
> of 7).  When I run mythcommflag, I get the message in the subject
> line.  Although the recording is marked as "commflagged", no
> commercial breaks are detected.
> 
>         I can manually change the database setting to 7 and commercial
> flagging works as normal.  However, wouldn't this mean that the
> database setting should be updated each time a new method is added?
> 
>         Also, the CommercialSkipMethod setting in
> programs/mythfrontend/globalsettings.cpp still uses a hard-coded value
> of 255 for "All Available Methods".

I've removed the hard codes, and added an automated update for the
commercial flagging in [17381]. This allows all commercial flagging
methods that you could select via the UI before to work.

But the reason it failed is due to a bug in
  ClassicCommDetector::getCommercialBreakList()
which didn't treat the flag as a flag.

I have a patch for it which I've attached to ticket #5346 
as 5346-v1.patch It also allows more combinations of commercial
flagging methods in the classic flagger. But it needs some
more testing before I can apply it.

-- Daniel