[mythtv] [mythtv-commits] mythtv commit: r16256 by nigel

Nigel Pearson nigel at ind.tansu.com.au
Wed Feb 27 03:05:28 UTC 2008

> Heh.  Didn't see the change in [15982], but technically, this wasn't a
> typo.  The code checks for "<p>" tags or the "<br" part of a tag to
> catch either "<br>" or "<br />".

Tricky. Of course, I didn't read the code :-)
I was just auditing the diffs between trunk & fixes.

> That being said, I don't think it's worth changing the README back  
> as it
> probably makes more sense to the user in its current "corrected" form,
> even if it's not as precise as before.  As long as we don't  
> "correct" it
> in httpstatus.cpp, it should be fine.  :)

I will try to remember that!

Probably worth a comment? e.g.:

              if ((display.contains("<p>", false) > 0) ||
-                (display.contains("<br", false) > 0))
              if ((display.contains("<p>", false) > 0) ||
+                (display.contains("<br", false) > 0))   // matches  
<br> or <br />

In fact, the whole file could do with some Doxygenation.
Maybe in my spare time (when I add support for <P> and <BR :-)

Nigel Pearson, nigel at ind.tansu.com.au| "Peacemaking is our profession"
Telstra Net. Eng., Sydney, Australia |Motto of Burpelson Airforce Base
Office: 9202 3900    Fax:  9261 3912 |Commanded by Gen. Jack D. Ripper
Mobile: 0408 664435  Home: 9792 6998 |        Dr Strangelove

More information about the mythtv-dev mailing list