[mythtv] [mythtv-commits] Ticket #4804: Add software amplification support to libmyth/AudioOutput
chamilton at cs.dal.ca
Tue Apr 15 01:00:21 UTC 2008
>> Probably someone will pipe up and say whether the #define or my idea for a
>> generic function is a better idea or not. But since I would like to see
>> this patch or something like it get into the tree, I have integrated it
>> into my patch set and will continue to do what I can for it.
I wrote the original patch and I prefer your approach... funnily enough
I work with heavily templated code every day, and didn't even think to
do that here ;)
> since each codec is different its better to fix the gain of the codec. Mpeg2
> is the main culprit. there was a patch a while ago which added 10dB or
> something like it but since one of the ffmpeg merges it was lost.
> this would be the better solution.
This doesn't affect the software amp patch itself, and there are
potentially other uses for it as well (evening out volume level on
different television channels, etc). Also, it would be trivial to add
per decoder default gain values using the software pre-amp patch. But
that only makes sense if there is some provable difference in the gain
when the same song is encoded using different encoders...
More information about the mythtv-dev