[mythtv] Ticket #4109: LocalHostName should not default to "my-unique-identifier-goes-here"

Nigel Pearson nigel at ind.tansu.com.au
Sun Oct 28 23:49:31 UTC 2007


>> +    params.localEnabled  = params.localHostName.length() > 0;
>
> why not:
> +    params.localEnabled = !params.localHostName.isEmpty();

Stylistic -

I try not to use "!" if possible
(typographically, it is a small char - easy to miss),

and the >0 hopefully makes it obvious that
we are creating a boolean expression.

(not that there is any other option here,
  but when ints are erroneously used
  in place of bools, there is)




I might just change the hostname correcting to use:

     if (m_localhostname == NULL || m_localhostname == "my-unique- 
identifier-goes-here")


--
Nigel Pearson, nigel at ind.tansu.com.au|"Reality is that which-
Telstra Net. Eng., Sydney, Australia | when you stop believing-
Office: 9202 3900    Fax:  9261 3912 | in it, doesn't go away."
Mobile: 0408 664435  Home: 9792 6998 | Philip K. Dick - 'Valis'


More information about the mythtv-dev mailing list