[mythtv] [mythtv-commits] Ticket #4179: (patch included) BackendQueryDiskSpace incorrectly aggregates identical local disks

[Chris Moates]

Rob Smith wrote:
> On Nov 17, 2007 8:55 AM, Michael T. Dean <mtdean at thirdcontact.com> wrote:
>   
>> See the thread at
>> http://www.gossamer-threads.com/lists/mythtv/users/280805#280805 .  Note
>> that Chris Pinkham (one of the responders in that thread) is the author
>> of the code that identifies the "unique" disks (and the rest of the
>> Storage Groups code, too), so his posts are a bit more than armchair
>> quarterbacking.
>>
>> There, we agreed that a false positive test for uniqueness is /far/
>> better than a false negative test.
>>
>> Mike
>>     
>
> Well, I'm gonna interject some armchair quarterbacking.
>
> Thoughts on just having a simple file in the root dir of each storage
> dir that uniquely identifies it? I'd suggest .storage_group_uuid or
> similar, that way it's 'invisible' but easily findable.
That was already considered, but it fails when two mounts have the same 
parent device. For example
/mnt/sda1/simpsons
/mnt/sda1/house

These two would have separate "root dirs" and they would have separate 
UUID's, even though they are physically on the same disk.

Unrelated, I attached my final version of the patch to this ticket 
(4179) earlier this afternoon. I tested it with both NFS and local 
double-mounted and single-mounted disks and it functions as expected. I 
did not test with SMB or similar, but assuming their isLocal flag is set 
properly, this won't be an issue.

Chris