[mythtv] [mythtv-commits] Ticket #4179: (patch included) BackendQueryDiskSpace incorrectly aggregates identical local disks
Michael T. Dean
mtdean at thirdcontact.com
Sat Nov 17 19:59:28 UTC 2007
On 11/17/2007 01:35 PM, Chris Moates wrote:
> I am finishing up a patch that will still prefer false positives, but
> reduce the false rate a bit. Short version, if the disks are both local,
> and have the same st_dev from stat(), then they are the same device, and
> can be merged. If the st_dev numbers are different, then the devices are
> unique, and should not be merged. If stat() fails, then we fall back to
> the way it was before my patch, using only disk capacity and free space.
> The st_dev method is the same way df works, so it seems likely to be
> reliable.
Yeah. I finally got around to catching up on the IRC scrollback (I
always do mail first, then IRC) and saw your conversation with Chris.
Sounds (and your patch looks) like a good approach.
Mike
More information about the mythtv-dev
mailing list