[mythtv] [PATCH] OSD glitch - starts as 4:3 and corrects to 16:9
danielk at cuymedia.net
Thu May 24 14:06:02 UTC 2007
On Thu, 2007-05-24 at 23:45 +1000, Matt Doran wrote:
> It wasn't the constructor. It took me a while to figure out how the
> video playback process works ... but I got there eventually. :) In a
> method in NuppelVideoPlayer called OpenDummy which sets up the dummy
> video while waiting for the channel to tune.... it sets the video size
> arbitrarily to 720x576 and aspect of 1.3333. At this point we don't
> have access to the display size. We don't know that until in the
> InitVideo method.
> So my fix was to set the force the video aspect to the display aspect if
> we're in dummy mode. It works very nicely. Now when I start to watch
> live tv, the OSD appears at the full width (16:9). I don't get the
> ugliness of switching from the default 4:3 to 16:9 when the video starts.
> The patch was only a couple of lines, and it results in much more
> polished results. :)
> What do you think?
It looks like a decent enough hack. It will still chose the
wrong video aspect ratio whenever you view a non-16:9 stream
on a 16:9 screen, but at least it will default to filling the
screen for 16:9 screens so it's an improvement. What I would
like to see down the road is some intelligent guessing as to
the aspect ratio. If we are about to view channel X and the
last time we viewed it the resolution and aspect ratio were Y,
then we should start with Y when we start on channel X. If we
are using xrandr we really want to minimize these changes.
Can you open a ticket with your hack?
More information about the mythtv-dev