[mythtv] [mythtv-commits] Ticket #3041: MythMusic scanning improvements

[Steven Adeff]

On 3/21/07, Stuart Morgan <stuart at tase.co.uk> wrote:
> On Tuesday 20 March 2007 22:17:30 Stuart Morgan wrote:
> > I've attached a new patch to #3041 which makes use of the Xing header for
> > VBR mp3s to calculate the track length. This should be several times
> > faster. I'd appreciate some feedback - you'll need some VBR mp3s with Xing
> > headers to benefit (Lame for example creates a Xing header).
>
> I did some better testing/benchmarking of this method.
>
> Using a sample of 2018 mp3s (mixed VBR/CBR, various lengths):
> Full Scan Without Patch: 26 minutes
> Full Scan With Patch: 6 minutes 32 seconds
>
> Of the 2018 mp3s, 5 had a difference in length (over 0.03 seconds) compared to
> the old calculation. All the new lengths were more accurate than previously
> calculated.
>
> Having got some solid (positive) figures on the accuracy I'll probably commit
> this soon.
>
> N.B. The patch, or scanning in general leaks a small amount of memory. This
> will be fixed but shouldn't affect testing. Exiting mythmusic frees the
> memory.

wow, nice!
any chance you can look at improving how mythmusic handles mp4/aac files?
I know I know, gift horse, mouth, etc.... =)

-- 
Steve
Before you ask, read the FAQ!
http://www.mythtv.org/wiki/index.php/Frequently_Asked_Questions
then search the Wiki, and this list,
http://www.gossamer-threads.com/lists/mythtv/
Mailinglist etiquette -
http://www.mythtv.org/wiki/index.php/Mailing_List_etiquette