[mythtv] [mythtv-commits] Ticket #3641: Add MythWeb preview images to myth.find_orphans.pl -script

[Michael T. Dean]

On 06/20/2007 01:49 AM, Otto Kolsi wrote:
> Michael T. Dean wrote:
>   
>> And, BTW, does this script even find orphans on your system?  If so, we
>> should fix the problem, not the symptom.  There are no orphan videos or
>> previews on my system.
...
> What I don't get is that you mentioned that you have above like 'sized' 
> preview images.. and still no orphans. When I execute the script 
> without any params, it reports all of those 'sized' thumbnails as 
> orphans.. Or did you check by hand that those are all valid and did not 
> use the script?
>   

I've actually never used the myth.find_orphans.pl script (which is much
of the reason I didn't post a patch for it).  I don't install it since
I've never had a need for it since I don't get orphans.  (I'll admit
that I don't transcode recordings, so the transcoding case hasn't
affected me.  And, I've only ever used LiveTV for testing capture cards,
so if there's a bug there that results in orphans, it hasn't affected
me, yet.)

(I also think the script should be rewritten to use the Perl
bindings--along with several other scripts in contrib--and won't install
it on my system until that's been done.  I'm not a big fan of copy and
paste bug reuse.  But, that's a whole other story.)

But, to verify that I don't have orphans, I wrote a tiny little bash
script to verify that for every PNG preview, the corresponding mpg/nuv
file exists (and I have the exact number of mpg/nuv files as rows in
recorded, so I know there are no orphan recordings), so when I said,
"There are no orphan videos or previews on my system," I meant real
orphans (not ones that would be incorrectly identified as orphans).  I
just used other means to verify.

The transcoding case sounds like the first problem to fix, so perhaps
after that, you'll see far fewer orphans.  Thank you for identifying the
bug so it can be fixed.  I may write a patch before long (especially
since I'm planning to do some other work in that area of the code).

Mike