[mythtv] Minor fixes to mythlcdprocclient.cpp

Paul Harrison mythtv at dsl.pipex.com
Sun Jul 8 08:49:22 UTC 2007


Thien Vu wrote:
> Hi,
>
> I have a Shuttle M1000 that has a 1 row, 20 character display. It
> seems that mythlcdprocclient.cpp assumes the LCDs are at least 3 rows
> tall, which causes some screens to not show anything useful. I started
> grokking the code base and will be making more changes in the future.
> The first thing is to fix some minor off-by-one errors since LCD
> addressing starts at 1 and not at zero.
>
> http://www.thien-vu.dyndns.org/~thien/mythtv-svn-lcd-fixes.diff
>
> Thanks,
>
> Thien
>

Actually the LCD code will work fine with LCDs with two or more lines so
your first assumption is incorrect. All the code does assume there are
at least two lines available though and will require a lot of change to
make it work with one line displays.

The off by one patch you supplied is incorrect. The top line (topWidget)
shows the menu name and then any other lines available (menuWidgetX)
show the menu items so the code as it stands is correct.

Paul H.
 


More information about the mythtv-dev mailing list