[mythtv] [mythtv-commits] Ticket #2557: SIGSEGV in Mythmusic

[Stuart Morgan]

Eskil wrote:
>  The thread unsafe methods weren't really added in [8175], the were just
>  moved from MythContext to MythObservable. I've never seen any ill effects
>  of this patch, but then again, I pretty much only use MythVideo and
>  MythMusic.

Eskil - If I'm wrong about [8175] I apologise, the diffs from [8174] to [1875] 
gave the impression that firstListener, nextListener and getListeners were 
added then. Not that I think it was removing those in [12578] which caused 
problems, it was just an observation.

Brian wrote:
>  I've been using this patch since the beginning of November (even with the
>  latest SVN) and it's been working great.

There is no doubt that the patch was causing serious problems, at least five 
people reported issues touching upon just about every area of Mythtv that 
uses the listeners code. I just didn't test long enough to encounter any 
issues.

Eskil wrote:
>  Short of removing get/next/first listener, the only thing this patch
>  really does is add a mutex to prevent modifying the listener list while
>  someone is dispatching.

I'm still trying to figure out what caused the problems. I may break the patch 
down into parts and try to find the cause that way. I'm as surprised as you 
are - I can't see why adding locks to those functions would cause the sorts 
of problems seen by everyone.
-- 
Stuart Morgan