[mythtv] Compiler Warnings on OSX that may indicate problems

[Daniel Kristjansson]

Below are the compiler warnings remaining on OSX...

The httprequest.cpp and bufferedsocketdevice.cpp appear to
indicate real problems, random data can be returned when
an object is missing. I didn't fix these in because I'm
not sure what should be returned when the object is missing.

The mpeg2fix.cpp problems look like the API was changed so
that a function returned false on an error but there are
still places where we check for a return value less than 0
for an error...

I think the rest of the warnings indicate some not yet
implemented code.

-- Daniel

================= Compiler Warnings on OSX ====================

hdhomerun/hdhomerun_discover.c: In function
`hdhomerun_discover_send_internal':
hdhomerun/hdhomerun_discover.c:201: warning: unused parameter `ds'
hdhomerun/hdhomerun_discover.c:201: warning: unused parameter
`device_type'
hdhomerun/hdhomerun_discover.c:201: warning: unused parameter
`device_id'
mythuiimage.cpp: In member function `virtual void
   MythUIImage::DrawSelf(MythPainter*, int, int, int, QRect)':
mythuiimage.cpp:197: warning: unused parameter `QRect clipRect'
mythuitext.cpp: In member function `virtual void
   MythUIText::DrawSelf(MythPainter*, int, int, int, QRect)':
mythuitext.cpp:124: warning: unused parameter `QRect clipRect'
httprequest.cpp: In member function `virtual bool
   BufferedSocketDeviceRequest::IsBlocking()':
httprequest.cpp:1204: warning: control reaches end of non-void function
bufferedsocketdevice.cpp: In member function `
   BufferedSocketDevice::BufferedSocketDevice(int)':
bufferedsocketdevice.cpp:27: warning: unused variable `linger ling'
main.cpp: In function `void* run_priv_thread(void*)':
main.cpp:38: warning: missing initializer for member
`sched_param::opaque'
main.cpp: In function `void* run_priv_thread(void*)':
main.cpp:698: warning: missing initializer for member
`sched_param::opaque'
CommDetector2.cpp: In function `QString commDetector2::strftimeval(const
   timeval*)':
CommDetector2.cpp:296: warning: long int format, int arg (arg 3)
CommDetector2.cpp:296: warning: long int format, int arg (arg 4)
avi.c: In function `new_idx_frame':
avi.c:96: warning: comparison between signed and unsigned
avi.c: In function `get_avi_from_index':
avi.c:426: warning: comparison between signed and unsigned
avi.c:457: warning: comparison between signed and unsigned
mpeg2fix.cpp: In member function `int MPEG2fixup::PlaybackSecondary()':
mpeg2fix.cpp:1453: warning: comparison is always false due to limited
range of
   data type
mpeg2fix.cpp: In member function `MPEG2frame*
MPEG2fixup::DecodeToFrame(int,
   int)':
mpeg2fix.cpp:1484: warning: comparison is always false due to limited
range of
   data type
mpeg2fix.cpp:1513: warning: comparison is always false due to limited
range of
   data type