[mythtv] Updated patch for directshow filters with MythTV (for CoreAVC)
Alan Nisota
alannisota at gmail.com
Fri Feb 9 03:47:39 UTC 2007
Andrew Lyon wrote:
> Alan,
>
> Not sure what was happening last night but I've got it working now,
> although I cannot get libdshowloader to compile as part of myth, I
> have to cd dshowloader , make.
>
> If course the colours are still wacked, were the samples of any use to
> you? do you need any more?
So the 1.1 patch has 2 issues that are trivial to fix:
1) Hanging when trying to exit:
Index: libs/libdshowloader/win32.c
===================================================================
--- libs/libdshowloader/win32.c.orig 2007-02-08 19:46:14.000000000 -0800
+++ libs/libdshowloader/win32.c 2007-02-08 19:35:10.000000000 -0800
@@ -1961,7 +1961,7 @@
pthread_mutex_lock(ml->pm);
if (prev_count != 0) *prev_count = ml->semaphore;
- if (ml->semaphore == 0) pthread_cond_signal(ml->pc);
+ if (ml->semaphore == 0) pthread_cond_broadcast(ml->pc);
ml->semaphore += increment;
pthread_mutex_unlock(ml->pm);
dbgprintf("ReleaseSemaphore(semaphore 0x%x, increment %d,
prev_count 0x%x) => 1\n",
2) Screwed up colors:
Index: libs/libdshowloader/dshow/DS_VideoDecoder.c
===================================================================
--- libs/libdshowloader/dshow/DS_VideoDecoder.c.orig 2007-02-08
19:46:14.000000000 -0800
+++ libs/libdshowloader/dshow/DS_VideoDecoder.c 2007-02-08
19:40:50.000000000 -0800
@@ -556,7 +556,6 @@
int stoped = 0;
Debug printf("DS_VideoDecoder_SetDestFmt (%p, %d,
%d)\n",this,bits,(int)csp);
-return 0;
/* if (!CImage::Supported(csp, bits))
return -1;
As for the make problem, I'm not really sure. I'll need to dig into it
some more.
More information about the mythtv-dev
mailing list