[mythtv] [mythtv-commits] Ticket #3041: MythMusic scanning improvements

[Peter Stokes]

On Wednesday 07 February 2007 20:14, Stuart Morgan wrote:
> On Wednesday 7 February 2007 19:40, Stuart Morgan wrote:
> > On Wednesday 7 February 2007 19:11, Daniel Kristjansson wrote:
> > > On Wed, 2007-02-07 at 19:03 +0000, MythTV wrote:
> > > > #3041: MythMusic scanning improvements
> > > > Comment (by stuartm):
> > > >
> > > >  (In [12744]) Refs #3041
> > > >
> > > >  NOTE: This commit may break or negatively impact the performance of
> > > >  mythmusic. I'm committing it in this possibly broken state before it
> > > >  becomes larger and harder to handle.
> > >
> > > Why not create a branch for these changes?
> >
> > It didn't really seem necessary as I expect to have these particular
> > changes finished within a week, maybe even in a couple of days if I have
> > the time.
>
> I should add, that the warning on that commit was just a precaution. In
> fact mythmusic, including scanning, continues to work on my machines. It's
> possible that a lesser used feature or Paul's new import stuff is currently
> broken, but people should be able to continue using mythmusic without major
> problems.

This commit doesn't compile for me, there appears to be a problem with the if 
statement on line 414 (probably missing braces?)

I also recieved the following error from the schema update (once I'd put some 
braces in to make it compile).

"Query was: INSERT INTO music_songs SELECT FROM tmp_songs;
Error was: Driver error was [2/1064]:
QMYSQL3: Unable to execute query
Database error was:
You have an error in your SQL syntax; check the manual that corresponds to 
your MySQL server version for the right syntax to use near 'FROM tmp_songs' 
at line 1"

Thanks

Pete