[mythtv] Request: MythHelp

usleepless at gmail.com usleepless at gmail.com
Wed Feb 7 20:32:37 UTC 2007


On 2/7/07, Stuart Morgan <stuart at tase.co.uk> wrote:
> On Wednesday 7 February 2007 18:47, usleepless at gmail.com wrote:
> > how do i submit 23 files to trac? or should i concat them?
> >
> > i created the diffs with:
> >   svn diff abc.cpp > abc.cpp.diff
> >
> > it that right?
> Using svn diff is correct, but you can specify more than one file at a time, a
> directory or nothing at all, in which case it will diff all changed files.
> e.g. svn diff libs/ > libs.diff
>        svn diff file1.cpp, libs/file2.cpp, libs/mythui > the.diff
>        svn diff > all.diff
> Rules are:
> One diff should be used for closely related changes. Mixing simple changes in
> with more complicated issues isn't advisable - it will quite likely delay the
> simple changes being applied, or the whole lot may even be rejected. Remember
> that the less time it takes to review and commit, the better for the devs who
> are looking at tickets in addition to their own work.
> A separate ticket should be opened for each bug or feature. So if you've only
> been addressing .size() related issues, a single ticket will be ok.

thanks for the info. are there no rules about path relativity?

i went to libs/libmythtv and did "svn diff > patchfile"

is that ok? or should i go up and do "svn diff libs/libmythv > patchfile"?

anyways, i wasted 2 trac-tickets on it, and the libmythtv-size-removal
patch is at:

those who have volunteered to give it a try: please do so.

it would be an awful discovery to find mysql actually "needs" the
.size() calls...



More information about the mythtv-dev mailing list