[mythtv] [mythtv-commits] Ticket #4263: Svn 15037 --Compile error osdtypes.cpp: In member function 'QString

[Anduin Withers]

> The problem was that the ./configure test was checking the pkg-config
> version, rather than the fribidi version. i.e. using --version, not
> --mod-version. I rewrote this using --atleast-version. But if you
> could make your patch work with both fribidi 0.10.x and fribidi 0.19+
> I'm sure a lot of people using distro fribidi packages would appreciate
> it. Using ifdef's so that it's easy to remove 0.10.x compatibility in a
> few years time might be the best option, adding another pkgconfig test
> for a 0.10.x define is fairly simple.

The only incompatibility I noted in the portion of fribidi used was that the
newer version of fribidi_charset_to_unicode is const correct. My patch
should have worked for both versions, at a minimum it does no worse than the
code it replaced.

My interest in fribidi does not extend past it failing to compile with older
versions. My guilt is assuaged by the knowledge that I do not know for a
fact the only thing preventing 0.10.x usage is that operator const char *()
was chosen over data().

-- 
Anduin Withers