[mythtv] [mythtv-commits] Ticket #3302: Do not update mfdb min/max hour for MythFillGrabberSuggestsTime

[Michael T. Dean]

On 04/13/2007 11:14 PM, Chris Pinkham wrote:
> * On Fri Apr 13, 2007 at 11:26:21AM -0400, Michael T. Dean wrote:
>   
>>> I was just thinking along similar lines, that it might be nice if it
>>> could "ignore" the mix/max time if Suggests was set...
>>>       
>> That would be very easy to do, too (basically delete one line as it's 
>> already in a section of code specific to those using suggested run 
>> time).  Thoughts, Chris?  This would obviate the need to even mess with 
>> changing the min hour setting.
>>     
>
> Fine by me, makes sense.
>   
>> Yeah.  The automatically setting them part probably should be done, too, 
>> if we don't remove the check against min/max hour.  It wouldn't be hard 
>> to do that while graying out the options in the settings screen.  If we 
>> leave the min/max check in there, I'll make sure it automatically sets 
>> them, too.
> Yeah, as long as the actual settings are disabled when we set them to sane
> options, then we could get rid of the set in the grabber as well.  This
> is going to be a bit more work for you though messing with the triggers
> in the settings code.

I was thinking if we ignore the values, we won't worry about 
automatically setting them in mythtv-setup (or the grabber).  That way, 
it "remembers" the values the non-North-American user had specified when 
he accidentally checked the grabber suggests time setting, so when he 
unchecks it, all is good again.  I posted a patch that takes this approach.

As far as the the settings page goes, I think putting a warning about 
min/max being ignored in the grabber suggests time help text is good.  
It seems we should also say so for the min/max hour settings, but the 
help text associated with those is already long, so it's probably better 
left out of there.

Also, if we're just ignoring the min/max hour, do we want to even 
disable the min/max hour spin boxes when the user checks grabber 
suggests time?  If a non-NA user checks it (because it sounds like the 
right thing to do), the times would not be ignored (since they're only 
ignored if grabber supports next time and MythFillGrabberSuggestsTime is 
enabled).

I posted a trivial help text change patch also and would be happy to add 
the code to disable the spin boxes when the user enables 
MythFillGrabberSuggestsTime if you want.  I may do it, anyway, so it's 
there if desired, but I have to learn a bit more about the QT GUI stuff.

Mike