[mythtv] [mythtv-commits] Ticket #3302: Do not update mfdb min/max hour for MythFillGrabberSuggestsTime

Michael T. Dean mtdean at thirdcontact.com
Fri Apr 13 15:26:21 UTC 2007

On 04/13/2007 10:27 AM, aaron wrote:
> On 13/04/07, Chris Pinkham <cpinkham at bc2va.org> wrote:
>> I was going to comment on this when I saw the thread and ticket opened, but
>> now don't have to as much. :)  I agree that we should be resetting
>> MythFillMinHour every day to make sure that our suggested time will be
>> honored.  It would be nice if we could get the min/max settings greyed out
>> in the settings page if MythFillGrabberSuggestsTime is turned on, but that's
>> not required to fix this bug.

I agree.  I'll put that on my (growing much faster than my available 
Myth-hacking time) list.  :)

> I was just thinking along similar lines, that it might be nice if it
> could "ignore" the mix/max time if Suggests was set...

That would be very easy to do, too (basically delete one line as it's 
already in a section of code specific to those using suggested run 
time).  Thoughts, Chris?  This would obviate the need to even mess with 
changing the min hour setting.

>  but then
> thought that might be too convoluted to implement cleanly. Disabling
> the options (and automagically setting them to sane values, I assume)
> is better than my idea. :)   And I agree: not needed right away.

Yeah.  The automatically setting them part probably should be done, too, 
if we don't remove the check against min/max hour.  It wouldn't be hard 
to do that while graying out the options in the settings screen.  If we 
leave the min/max check in there, I'll make sure it automatically sets 
them, too.

> I'll hopefully get a chance to put the patch in place this weekend

The mythtv-DataDirect-no_update_min_max_hour-20070413.patch should apply 
cleanly to 0.20-fixes, too.

> ...Note to self: disable the cron job I had set up to work around the
> issue... ;-)

Please do.  :)


More information about the mythtv-dev mailing list